Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashnode cms guide #7374

Merged
merged 25 commits into from May 3, 2024

Conversation

Adammatthiesen
Copy link
Contributor

@Adammatthiesen Adammatthiesen commented Mar 13, 2024

Add a new guide for Hashnode CMS

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:12pm

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@sarah11918
Copy link
Member

I know, I know! I promise I'll get to this one this week! So sorry, Adam.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Apr 9, 2024
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I ran through the guide and noticed a few things. There's also a code example that might need reformatting at the end of the guide.

src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
Adammatthiesen and others added 5 commits April 10, 2024 02:24
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – docs April 10, 2024 09:51 Inactive
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 11, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/cms/hashnode.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promised, and here I am!

This is really well done @Adammatthiesen ! I've made some suggestions both to tighten this up, and to nudge it more towards our current style. I can see and appreciate how you modeled this on an earlier CMS guide, and as we've now had to deal with 80 billion of these, we have refined our style a bit. Not gonna take that out on you, though! But, don't feel like, "But the other one did this!!" if you see tiny adjustments that contradict an earlier model.

See what you think of these changes and notably:

  • I added some numbered instructions, but I'm just doing this on GitHub directly so it was annoying for me to a) add the <Steps/> component from Starlight and b) preview/tweak indentation for code samples inside ordered steps. Either one of us can do that, even at the end when we double check the preview.
  • I'd love the top of the page to have the most minimal data fetching just showing a straight API call as per the linked page in docs. This is just the tiniest taste of what using this should look like, so you can yadda yadda yadda a bunch if you need to in these long code samples.

Ready for you to take a look at this now!

src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved
</body>
</html>
```
:::note
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A GOOD USE OF NOTE OMG. Well done.

@sarah11918
Copy link
Member

Hey @Adammatthiesen ! Just checking in and seeing whether you were still interested in finishing this one! I know we made you wait a while for initial reviews... so, fair. 😅

@Adammatthiesen
Copy link
Contributor Author

Hey @Adammatthiesen ! Just checking in and seeing whether you were still interested in finishing this one! I know we made you wait a while for initial reviews... so, fair. 😅

oh nuts, i just noticed this..... heh lots of good notes... and yes its the ghostCMS guide copy pasted... lol

Adammatthiesen and others added 8 commits April 25, 2024 13:00
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Contributor

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked under 5 minutes Amazing 🔥🔥 LGTM

src/content/docs/en/guides/cms/hashnode.mdx Outdated Show resolved Hide resolved

### Fetching data

Can we have a minimal example here?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current recipe is fairly minimal, the steps in line 62 could be trimmed down and put here but its repeated information which is 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarah put that in... not sure what example she was looking for... I honestly thought the guide was fairly minimal as is, as most the code was directly pulled and simplified a bit from my astro-hashnode integration 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SARAH WILL TAKE THE BLAME, lol

Lemme give a quick once over so we can get this puppy merged!

Co-authored-by: Atharva <atharvapise19@gmail.com>
@sarah11918
Copy link
Member

Thank you @Adammatthiesen -- I just went and added our new <Steps> component (that's how long it's taken us to get to this 😆 ) and assuming the deploy preview of the steps look good, I'll be merging! 🥳

@sarah11918
Copy link
Member

!coauthor

Copy link

github-actions bot commented May 3, 2024

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>

@sarah11918 sarah11918 merged commit 5f304ec into withastro:main May 3, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants