New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hashnode cms guide #7374
Add hashnode cms guide #7374
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
I know, I know! I promise I'll get to this one this week! So sorry, Adam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I ran through the guide and noticed a few things. There's also a code example that might need reformatting at the end of the guide.
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I promised, and here I am!
This is really well done @Adammatthiesen ! I've made some suggestions both to tighten this up, and to nudge it more towards our current style. I can see and appreciate how you modeled this on an earlier CMS guide, and as we've now had to deal with 80 billion of these, we have refined our style a bit. Not gonna take that out on you, though! But, don't feel like, "But the other one did this!!" if you see tiny adjustments that contradict an earlier model.
See what you think of these changes and notably:
- I added some numbered instructions, but I'm just doing this on GitHub directly so it was annoying for me to a) add the
<Steps/>
component from Starlight and b) preview/tweak indentation for code samples inside ordered steps. Either one of us can do that, even at the end when we double check the preview. - I'd love the top of the page to have the most minimal data fetching just showing a straight API call as per the linked page in docs. This is just the tiniest taste of what using this should look like, so you can yadda yadda yadda a bunch if you need to in these long code samples.
Ready for you to take a look at this now!
</body> | ||
</html> | ||
``` | ||
:::note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A GOOD USE OF NOTE OMG. Well done.
Hey @Adammatthiesen ! Just checking in and seeing whether you were still interested in finishing this one! I know we made you wait a while for initial reviews... so, fair. 😅 |
oh nuts, i just noticed this..... heh lots of good notes... and yes its the ghostCMS guide copy pasted... lol |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked under 5 minutes Amazing 🔥🔥 LGTM
|
||
### Fetching data | ||
|
||
Can we have a minimal example here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current recipe is fairly minimal, the steps in line 62 could be trimmed down and put here but its repeated information which is 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sarah put that in... not sure what example she was looking for... I honestly thought the guide was fairly minimal as is, as most the code was directly pulled and simplified a bit from my astro-hashnode
integration 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SARAH WILL TAKE THE BLAME, lol
Lemme give a quick once over so we can get this puppy merged!
Co-authored-by: Atharva <atharvapise19@gmail.com>
Thank you @Adammatthiesen -- I just went and added our new |
!coauthor |
|
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> Co-authored-by: Atharva <atharvapise19@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> Co-authored-by: Atharva <atharvapise19@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> Co-authored-by: Atharva <atharvapise19@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com> Co-authored-by: Atharva <atharvapise19@gmail.com>
Add a new guide for Hashnode CMS