Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull request template] Reminds new feature PRs to include <Since> #8173

Merged
merged 2 commits into from May 3, 2024

Conversation

sarah11918
Copy link
Member

Description (required)

This PR adds a reminder in the PR template to use the <Since> component when adding docs for a new or updated feature in an upcoming minor release.

<!-- 2. Check that your PR includes `<p><Since v="4.x.0" /></p>` and imports the `<Since>` component, if necessary! -->			

This is to provide another line of defense, as often Sarah forgets the first time editing. 😅

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:53pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 3, 2024 8:53pm

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@sarah11918
Copy link
Member Author

(Will note for historical record that <Since> can also take e.g. pkg="preact" attribute in case it's not an update to a version of Astro, but one of the packages instead. But, I'm betting on me noticing and fixing if and when that comes up! 😅

@sarah11918
Copy link
Member Author

!coauthor

Copy link

github-actions bot commented May 3, 2024

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

@sarah11918 sarah11918 merged commit af5edea into main May 3, 2024
7 of 8 checks passed
@sarah11918 sarah11918 deleted the sarah11918-patch-1 branch May 3, 2024 20:49
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
…ithastro#8173)

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
…ithastro#8173)

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…ithastro#8173)

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…ithastro#8173)

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants