Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify middleware examples #8176

Merged
merged 3 commits into from
May 4, 2024

Conversation

sasoria
Copy link
Contributor

@sasoria sasoria commented May 4, 2024

Description

This pull request simplifies the code examples in the section about middleware. I have removed any destructoring of the context object to make it easier to understand where it is located in the code.

Related issues & labels (optional)

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 4, 2024 9:08pm

@sasoria
Copy link
Contributor Author

sasoria commented May 4, 2024

I've been told to tag you here @ematipico. What do you think of this?

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 4, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/middleware.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label May 4, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sasoria ! I do think this is helpful!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 4, 2024
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone! LGTM ✅

@dreyfus92 dreyfus92 merged commit 9052ff7 into withastro:main May 4, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 11, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev added a commit that referenced this pull request May 14, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…thastro#8253)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…thastro#8253)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…thastro#8253)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

context.locals or locals?
5 participants