Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bun.mdx #8183

Merged
merged 3 commits into from
May 6, 2024
Merged

Update bun.mdx #8183

merged 3 commits into from
May 6, 2024

Conversation

jacobdalamb
Copy link
Contributor

Description (required)

Add note about Bun's new crash reporter added in 1.15

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 6, 2024 2:46pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 6, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en recipes/bun.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr reviewed May 6, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done Jacob 🔥 Minor typo caught and should be resolved quickly ⚡

src/content/docs/en/recipes/bun.mdx Show resolved Hide resolved
src/content/docs/en/recipes/bun.mdx Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Hi Jacob! This change is not really appropriate for Astro docs. It's not something we need to mention, as it's not about Astro itself!

@sarah11918 sarah11918 closed this May 6, 2024
@sarah11918 sarah11918 reopened this May 6, 2024
@sarah11918
Copy link
Member

Ooh, I missed the change to the opening line! I think that's great to have here!

sarah11918
sarah11918 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing things that refer to time! Change to the first sentence is great!

But, we already say "open an issue" and adding extra information about how Bun works isn't really of concern here, so I'll merge the helpful opening sentence!

src/content/docs/en/recipes/bun.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label May 6, 2024
@sarah11918
Copy link
Member

!coauthor

1 similar comment
@sarah11918
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>

@sarah11918 sarah11918 merged commit 4f08665 into withastro:main May 6, 2024
7 of 8 checks passed
@jacobdalamb jacobdalamb deleted the chore/bun-report-recipe branch May 6, 2024 16:03
@liruifengv liruifengv mentioned this pull request May 7, 2024
Merged
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Update bun.mdx (withastro#8183)
3faa1e0 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 12, 2024
@thomasbnt
i18n(fr): Update bun.mdx from withastro#8183
93958e7 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request May 12, 2024
Merged
yanthomasdev added a commit that referenced this pull request May 14, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update bun.mdx from #8183 (#8261)
2a9b99a 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Update bun.mdx (withastro#8183)
014559d 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @yanthomasdev @wpplumber
i18n(fr): Update bun.mdx from withastro#8183 (withastro#8261)
bc022f3 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Update bun.mdx (withastro#8183)
871946e 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @yanthomasdev @wpplumber
i18n(fr): Update bun.mdx from withastro#8183 (withastro#8261)
847c0eb 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @yanthomasdev @wpplumber
i18n(fr): Update bun.mdx from withastro#8183 (withastro#8261)
5fdf6e5 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@jsparkdev jsparkdev mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@at-the-vr at-the-vr at-the-vr left review comments

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobdalamb @astrobot-houston @sarah11918 @at-the-vr