-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api-reference.mdx #8373
Update api-reference.mdx #8373
Conversation
The description for Astro.redirect() makes no mention of the optional second parameter, so I added a note about it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thanks for this @hfournier ! We should absolutely be showing this! I took a quick editing pass to work the content into the actual description, since we don't like to add essential content by tacking on notes. (Docs can start to look pretty wild if we overuse that pattern!) Take a look at the version I have and see whether you'd suggest any changes! |
That looks good to me... and thanks for the heads up on not overusing notes on future updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you so much, let's do this!
The description for Astro.redirect() makes no mention of the optional second parameter, so I added a "note" about it.
Description (required)
The description for Astro.redirect() makes no mention of the optional second parameter, so I propose adding a "note" that it accepts an optional HTTP Status Code (linked it to MDN), and that the default is 302.
Related issues & labels (optional)