-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sticky TOC on mobile devices and medium viewports #927
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
@delucis @Yan-Thomas PTAL :) |
I don't know why my evil phone was not also pinged for a PTAL, but fwiw, you have appeased even Sarah's phone with this upgrade, Hippo! I have none of my earlier issues re: completely disappearing TOC if you clicked on a section to navigate there. |
Oops, my bad! I wanted to ping you, too. I just talked to Chris earlier today that I was really curious what issues your phone could come up with! Really glad to hear that there are none. I was expecting some epic final boss battle to make your phone happy, too! 😄 |
LGTM! Thanks for all the improvements! 💯🦛💜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! A couple of small things and one bigger question that isn’t a complete blocker, but would be good to investigate.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much Hippo! A great improvement 🚀
What kind of changes does this PR include?
Description
Improves the sticky TOC on mobile devices like iOS Safari:
Improves the sticky TOC on all devices with medium viewports:
Cleanup: Reduced magic numbers across the CSS code by moving them to clearly named variables in
public/theme.css
.