Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 RFC: Support Svelte 4 #589

Closed
2 of 3 tasks
ghostdevv opened this issue Jun 22, 2023 · 3 comments
Closed
2 of 3 tasks

💡 RFC: Support Svelte 4 #589

ghostdevv opened this issue Jun 22, 2023 · 3 comments

Comments

@ghostdevv
Copy link

ghostdevv commented Jun 22, 2023

Background & Motivation

Svelte 4 was released today so would be great to support it, unfortunately it doesn't seem language tools does currently. Sent a draft PR to astro to work on supporting it in the code there withastro/astro#7454. A list of breaking changes can be found here, but specifically I think we need to worry about:

breaking: Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) (sveltejs/svelte#8488)

breaking: Deprecate SvelteComponentTyped in favor of SvelteComponent (sveltejs/svelte#8512)

There may be more but I haven't looked at the implementation here. Happy to try and work on a pr at the end of this week if no one else wants to pick it up (may take some time to figure out as I am unfamiliar with the codebase).

Proposed Solution

n/a

Detailed Design

No response

Help make it happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
@bluwy
Copy link
Member

bluwy commented Jun 23, 2023

Can you explain how language-tools isn't working with Svelte 4? It's working fine for me.

@Princesseuh
Copy link
Member

Princesseuh commented Jun 23, 2023

Yeah, since we updated to the latest version of svelte2tsx some time ago, it should already be working as far as I know. Either way, the code to support this doesn't actually live in this repo, it's in the Svelte integration

@ghostdevv
Copy link
Author

Nevermind it's working for me now 🙏

@ghostdevv ghostdevv closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants