Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte Four #7454

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Svelte Four #7454

merged 3 commits into from
Jun 25, 2023

Conversation

ghostdevv
Copy link
Contributor

@ghostdevv ghostdevv commented Jun 23, 2023

Changes

Adds support for svelte 4 in @astrojs/svelte, we need support for this in language tools as well before it can be merged, so I created this issue withastro/language-tools#589

Testing

Tested locally

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 840da6b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Jun 23, 2023
@bluwy
Copy link
Member

bluwy commented Jun 23, 2023

I don't think this needs to be blocked if language-tools isn't ready. IIUC we only need to loosen the peer dep range.

@ghostdevv ghostdevv marked this pull request as ready for review June 24, 2023 23:14
@ghostdevv
Copy link
Contributor Author

I think these are all the changes needed then?

@bluwy
Copy link
Member

bluwy commented Jun 25, 2023

Yup 👍

@bluwy bluwy merged commit 6e7f38d into withastro:main Jun 25, 2023
13 checks passed
@ghostdevv ghostdevv deleted the svelte-4 branch June 25, 2023 14:33
@astrobot-houston astrobot-houston mentioned this pull request Jun 25, 2023
akshit20421 added a commit to akshit20421/astro that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants