Load language integrations from the user project #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a25698 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
changed the title
…nal-language-integrations
Princesseuh
commented
Jul 11, 2022
| @@ -1,5 +1,6 @@ | |||
| .github | |||
There was a problem hiding this comment.
This is unrelated to this specific PR, just something I missed in #334
matthewp
reviewed
Jul 13, 2022
|
|
||
| if (diagnostic.message.includes('.vue')) { | ||
| diagnostic.message += | ||
| '\n\nIs the `@astrojs/vue` package installed? You can add it to your project by running the following command: `astro add vue`. If already installed, restarting the language server might be necessary in order for the change to take effect'; |
|
Just needs a changeset. |
Princesseuh
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit 4b73c21.
Princesseuh
added a commit
that referenced
this pull request
Jul 13, 2022
…"" This reverts commit c8c29ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Editor tooling part of withastro/astro#3864
This deprecate both
@astrojs/svelte-language-integrationand@astrojs/vue-language-integrationThis makes the language-server about 600 files lighter and about 10mb~ less. Since we need those integrations in dev, this only affects users and not developers, but that's okay
Testing
Our current tests already cover importing and doing stuff with Vue and Svelte components. Adding the integrations as dev dependencies is enough to have them inside fixtures
Not sure if anything more is needed here, testing the package imports would be testing that Node's require work
Docs
Will tell people in my announce message. I'll monitor #support-threads after to see if we need to document this more heavily or not, it shouldn't technically affect many people (if you're using Svelte, you're likely to have the Svelte integration, I think?)