Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(syntax): Use a YAML file to generate the final syntax #461

Merged
merged 3 commits into from Dec 27, 2022

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Dec 27, 2022

Changes

Inspired by Svelte's language-tools, this moves our syntax file to a yaml file that is then converted to JSON for publishing.

This has a lot of benefits:

  • Much easier to author
  • Much easier to read
  • Allow us to use real comments

We kept the exact same feature set while using half as much lines

Fix #459

Testing

Updated snapshots to account for the changes

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2022

⚠️ No Changeset found

Latest commit: 8513a98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Princesseuh Princesseuh marked this pull request as ready for review December 27, 2022 15:30
@Princesseuh Princesseuh requested a review from a team as a code owner December 27, 2022 15:30
Copy link
Collaborator

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Princesseuh Princesseuh self-assigned this Dec 27, 2022
@Princesseuh Princesseuh merged commit 986a230 into main Dec 27, 2022
@Princesseuh Princesseuh deleted the feat/use-yaml-syntax branch December 27, 2022 21:09
@lildude
Copy link

lildude commented Mar 8, 2023

👋 from GitHub's Linguist library which uses this grammar for syntax highlighting of Astro files on GitHub.com.

This PR has removed the packages/vscode/syntaxes/astro.tmLanguage.json file and hasn't replaced it with a version GitHub can use so we can no longer update the submodule to pull in your grammar changes.

@Princesseuh
Copy link
Member Author

Princesseuh commented Mar 8, 2023

Hello! I'll add the built file to the repo as well. Sorry for the inconvenience!

@Princesseuh
Copy link
Member Author

👋 from GitHub's Linguist library which uses this grammar for syntax highlighting of Astro files on GitHub.com.

This PR has removed the packages/vscode/syntaxes/astro.tmLanguage.json file and hasn't replaced it with a version GitHub can use so we can no longer update the submodule to pull in your grammar changes.

Fixed, sorry again for the inconvenience!

@lildude
Copy link

lildude commented Mar 8, 2023

🎉 Perfect! Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 RFC: Master CSS Language Service doesn't work
3 participants