Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the <Markdown> Component #184

Merged
merged 1 commit into from
May 3, 2022
Merged

Deprecate the <Markdown> Component #184

merged 1 commit into from
May 3, 2022

Conversation

FredKSchott
Copy link
Member

  • Start Date: 2022-04-29
  • Status: Draft

Summary

Hey everyone! We (the core maintainers, @withastro/maintainers-core) have been discussing the <Markdown /> component a lot over the last few days, and have made the decision to deprecate the <Markdown /> component ahead of our v1.0 release. It will continue to be available as a non-core, user-land npm package (@astrojs/markdown) post v1.0.

This is a bit of an odd RFC in that it's driven by a need to fix a buggy experience, and not talking through the best way to add something new. We've been discussing this on the core team on-off for a few weeks now, and have already reached informal consensus within the group, but I would still like to share this with our larger maintainer community for feedback during the next RFC call.

For more details and why we see it as necessary, read on.

Links

History

  • Discussed on the 2022-04-26 RFC Call and was received positively. Will attempt official consensus at the next RFC call.

@delucis
Copy link
Member

delucis commented Apr 29, 2022

Couldn’t make it to the RFC call, but this all makes sense and the RFC reads well 👍

@brycewray
Copy link

brycewray commented May 1, 2022

I’ll humbly offer a “peanut gallery”-level comment because the Full Rendered Proposal explains all this superbly well: I hope that “userland plugin” will be available before <Markdown /> ceases to work — and I do see that this is the intent — because I can’t find a working or compatible plugin, whether Remark or Rehype, that substitutes for how I’ve been using <Markdown />. My use case is small, but it’s there. :) Thanks in advance for whatever consideration this receives!

Disregard. I will try a combination of options 1 and 2 under “Drawbacks & alternatives.” Workable enough.

brycewray added a commit to brycewray/astro-site-legacy that referenced this pull request May 2, 2022
brycewray added a commit to brycewray/astro-site-legacy that referenced this pull request May 2, 2022
brycewray added a commit to brycewray/astro-site-legacy that referenced this pull request May 2, 2022
brycewray added a commit to brycewray/astro-site-legacy that referenced this pull request May 2, 2022
@FredKSchott FredKSchott merged commit ac84788 into main May 3, 2022
@matthewp matthewp deleted the deprecate-markdown branch May 3, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants