Improve outside click detection on search modal (#85)

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
withastro · May 24, 2023 · c86c1d6 · c86c1d6
1 parent 1d2412f
commit c86c1d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/silver-icons-reflect.md b/.changeset/silver-icons-reflect.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/starlight": patch
+---
+
+Improve outside click detection on the search modal
diff --git a/packages/starlight/components/Search.astro b/packages/starlight/components/Search.astro
@@ -63,7 +63,7 @@ const t = useTranslations(Astro.props.locale);
 
       /** Close the modal if a user clicks outside of the modal. */
       const onWindowClick = (event: MouseEvent) => {
-        if (!dialogFrame.contains(event.target as Node)) closeModal();
+        if (document.body.contains(event.target as Node) && !dialogFrame.contains(event.target as Node)) closeModal();
       };
 
       const openModal = (event?: MouseEvent) => {