Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs component details #1031

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fix docs component details #1031

merged 3 commits into from
Nov 3, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 2, 2023

What kind of changes does this PR include?

  • Something else!

Description

  • Fixes two small details in our docs components that have been bugging me forever.

  • Removes the not-content class from the “About Astro” block on the homepage so that the link is the correct colour.

    Before After
    image image
  • Adds just enough margin to file-tree entries so that when two neighbouring entries are highlighted, they don’t touch.

    Before After
    image image

Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: 3f0209f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3f0209f
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/654429965e206200092da7de
😎 Deploy Preview https://deploy-preview-1031--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 2, 2023
@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 5.13 KB (0%)
/_astro/*.js 19.27 KB (0%)
/_astro/*.css 9.72 KB (0%)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat tweaks, looks perfect to me 🌟

@delucis delucis merged commit 0319bed into main Nov 3, 2023
10 checks passed
@delucis delucis deleted the chris/small-component-fixes branch November 3, 2023 16:34
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 5, 2023
* main: (103 commits)
  i18n(fr): update `guides/sidebar.mdx` (withastro#1033)
  i18n(fr): update `reference/configuration.mdx` (withastro#1034)
  i18n(fr): update `reference/frontmatter.md` (withastro#1035)
  Fix docs component details (withastro#1031)
  Overhaul getting started guide (withastro#1026)
  i18n(zh-cn): Update sidebar.mdx & configuration.mdx (withastro#1022)
  i18n(es): Update `configuration` & `sidebar` (withastro#1029)
  [ci] format
  i18n(zh-cn): Update frontmatter.md (withastro#1020)
  i18n(zh-cn): Update overrides.md (withastro#1021)
  i18n(zh-cn): Update i18n.mdx (withastro#1019)
  fix(docs-i18n-tracker): update `translations` import (withastro#1025)
  [ci] format
  i18n(zh-cn): Update css-and-tailwind.mdx (withastro#1018)
  [ci] format
  i18n(zh-cn): Update authoring-content.md (withastro#1016)
  i18n(ko-KR): update `configuration.mdx` (withastro#1015)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1014)
  i18n(ko-KR): update `i18n.mdx` (withastro#1013)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants