Expand testing #1045
Expand testing #1045
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
| @@ -164,6 +164,7 @@ | |||
| "astro": "^3.2.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@astrojs/markdown-remark": "^3.2.1", | |||
There was a problem hiding this comment.
Could this mean we could drop the dependency on unified and use the RemarkPlugin and RehypePlugin types exported from @astrojs/markdown-remark for our remark and rehype plugins?
Maybe also the RemarkPlugins constructed type in packages/starlight/src/integrations/asides.ts considering RemarkPlugins is also exported from @astrojs/markdown-remark?
There was a problem hiding this comment.
I added this as a dev dependency for testing only as I’d be a bit concerned about ending up accidentally depending on two different versions (one, the subdependency of a user’s astro version, the other a subdependency of Starlight).
I was looking at the asides typings the other day in relation to #517. Maybe there’s another way to get those types without unified? I might leave figuring that out to until the Astro v4 release as that’s planning to upgrade the whole unified/remark/rehype/MDX ecosystem, and lots of the types shifted in the most recent releases of those packages.
There was a problem hiding this comment.
Looks like we're all looking at these types ^^
I was looking at them too for #983 (which is definitely not as fun as I would have hoped ^^) where I am down to 4 TS errors which are all related to remark/rehype and after that it should get easier (js generation, "assets" copy and .d.ts generation are in place).
Maybe there’s another way to get those types without unified?
Yeah, that's something I need to explore a bit more, it's not the easiest eco-system to deal with type-wise imo ^^
There was a problem hiding this comment.
it's not the easiest eco-system to deal with type-wise imo
Absolutely not 😅 In general I think the types are good, but with the landscape of many, many small packages, it’s really easy to end up with conflicts between versions. Hopefully should be easier with Astro v4 because we should at that point be able to simply upgrade EVERYTHING to latest.
There was a problem hiding this comment.
Hopefully should be easier with Astro v4 because we should at that point be able to simply upgrade EVERYTHING to latest.
That would be so awesome indeed 🤞
I'm starting to think that #983 will need to wait for that change too. I'm down to 3 errors now all related to rehype/remark that I don't know how to properly fix due to the conflicting versions of @types/unist that we have.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What kind of changes does this PR include?
Description
<Tabs>component:::note,:::tipetc.)@astrojs/sitemapfor people based on their i18n config