Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Collective social icon #1254

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Add Open Collective social icon #1254

merged 3 commits into from
Jan 2, 2024

Conversation

Pukimaa
Copy link
Contributor

@Pukimaa Pukimaa commented Dec 8, 2023

Description

This PR aims to add an icon of Open Collective to the Icon Component. Open Collective is a crowdfunding platform also used by Astro itself, so it would only make sense to be added, right?

Preview of the openCollective Icon

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: b99f251

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 18, 2023 7:46pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 8, 2023
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed makes sense to me to add an Open Collective icon! Thanks for your help!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pukimaa — looks great! Left one small suggestion.

Could you also update branch? Looks like some checks are failing because it’s out of sync with main.

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 17, 2023
Pukimaa and others added 2 commits December 18, 2023 20:43
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@Pukimaa
Copy link
Contributor Author

Pukimaa commented Dec 18, 2023

Sure @delucis! We should be good to go now ^^

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience over the holidays @Pukimaa. This looks good to me — will aim to get a patch release out with this later today 🙌

@delucis delucis merged commit e9659e8 into withastro:main Jan 2, 2024
8 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants