-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Collective social icon #1254
Conversation
🦋 Changeset detectedLatest commit: b99f251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed makes sense to me to add an Open Collective icon! Thanks for your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pukimaa — looks great! Left one small suggestion.
Could you also update branch? Looks like some checks are failing because it’s out of sync with main
.
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sure @delucis! We should be good to go now ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience over the holidays @Pukimaa. This looks good to me — will aim to get a patch release out with this later today 🙌
Description
This PR aims to add an icon of Open Collective to the Icon Component. Open Collective is a crowdfunding platform also used by Astro itself, so it would only make sense to be added, right?