Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve social icons accessibility #1273

Merged
merged 5 commits into from
Dec 17, 2023
Merged

Improve social icons accessibility #1273

merged 5 commits into from
Dec 17, 2023

Conversation

natemoo-re
Copy link
Member

Description

Before
A 16px bounding box over the Discord logo

After
A 32px bounding box over the GitHub logo

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2023 •
edited

🦋 Changeset detected

Latest commit: 65b3079

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 17, 2023 3:13pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 12, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Dec 12, 2023 •
edited

size-limit report 📦

Path Size
/index.html 5.21 KB (+0.02% 🔺)
/_astro/*.js 21.42 KB (0%)
/_astro/*.css 13.04 KB (+0.08% 🔺)

@kevinzunigacuellar
Copy link
Sponsor Member

LGTM!

HiDeoo
HiDeoo approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the change, great improvement and this also brings them on par with the mobile search icon and mobile menu icon 👍 (and I guess the AAA level would look a bit weird for these icons as this would require some extra spacing between the icons)

ElianCodes
ElianCodes approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Nate! Looking fine 👌

delucis
delucis approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work @natemoo-re! Thank you for spotting this and prioritising it 💖

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 17, 2023
@delucis delucis merged commit ae53155 into main Dec 17, 2023
8 checks passed
@delucis delucis deleted the fix/social-link-target branch December 17, 2023 15:16
@astrobot-houston astrobot-houston mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

@ElianCodes ElianCodes ElianCodes approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@natemoo-re @astrobot-houston @kevinzunigacuellar @delucis @HiDeoo @ElianCodes