Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] docs: revert some translated default UI strings #1288

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Dec 18, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

While looking for something, I noticed that some of the default UI strings were translated in the docs site (I also checked all the other languages and they were fine).

This PR reverts those changes (note that the Spanish change is slightly bigger as it also fixes an indentation issue).

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 18, 2023 10:48am

Copy link

changeset-bot bot commented Dec 18, 2023

⚠️ No Changeset found

Latest commit: ddf780d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Dec 18, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Looks good to me and the i18nIgnore keyword is also good 👍

@HiDeoo HiDeoo merged commit 1fc6675 into withastro:main Dec 18, 2023
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 29, 2023
* main: (116 commits)
  [ci] format
  showcase: Add doc link of Mr. Robøt (withastro#1312)
  i18n(hi): update `project-structure.mdx` (withastro#1315)
  i18n(fr): Update `showcase.mdx` (withastro#1306)
  Add Concepto AI to Showcase Docs list (withastro#1307)
  showcase: Add docs.ghostfam.com (withastro#1314)
  i18n(ja): Update showcase.mdx and related pages (withastro#1294)
  i18n(ko-KR): update `showcase.mdx` (withastro#1304)
  docs: move `starlight-typedoc` to the community plugins section (withastro#1301)
  i18n(ja): Update frontmatter.md (withastro#1293)
  i18n(ko-KR): update `showcase.mdx` (withastro#1292)
  i18n(ko-KR): update `plugins.md` (withastro#1291)
  i18n(ko-KR): update `configuration.mdx` (withastro#1290)
  [ci] format
  [ci] release (withastro#1281)
  i18n(fr): add expressive code french translations (withastro#1289)
  [i18nIgnore] docs: revert some translated default UI strings (withastro#1288)
  i18n(fr): add plugin showcase (withastro#1287)
  i18n(fr): update `reference/frontmatter.md` (withastro#1286)
  docs: Add plugins showcase (withastro#1275)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants