Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable 404 page #1389

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

connor-baer
Copy link
Contributor

@connor-baer connor-baer commented Jan 22, 2024

Description

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 26, 2024 10:15pm

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 09302e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jan 22, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @connor-baer! This looks great to me even without the extra todo item — we can always tackle that later. Left one small suggestion on the docs, but the code seems spot on 🙌

docs/src/content/docs/reference/configuration.mdx Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 minor Change that triggers a minor release label Jan 25, 2024
@delucis delucis marked this pull request as ready for review January 26, 2024 19:17
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution @connor-baer! Hope you don’t mind I jumped in to polish up the last docs changes so we can get this released today.

Appreciate you helping out 🌟

@delucis delucis merged commit 21b3620 into withastro:main Jan 26, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 26, 2024
@connor-baer
Copy link
Contributor Author

@delucis, I don't mind at all, thanks for finishing this up! 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subpath: This route collides with: "src/pages/404.astro".
3 participants