Add JS support to @astrojs/starlight/expressive-code export
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 05b4fb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
delucis
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@astrojs/starlight/expressive-codeexport from a TS-only export to an.mjs+.d.tspair, using the exact configuration and file structure also used by Astro'sastro/configexport..mjs-based export working in projects using Astro'sstrictestTypeScript configuration that containsallowJs: false, it was required to move the exporting files into the package root folder using names that are identical to the export's name.defineEcConfighelper function and all other re-exports fromastro-expressive-code(which are important for advanced customization scenarios) to also work inec.config.mjsoutside of monorepos, where Astro's Vite instance does not process integration imports and therefore no TS support is available.getStarlightEcConfigPreprocessorfunction to@astrojs/starlight/internal, because it uses TS and therefore cannot remain in the previous@astrojs/starlight/expressive-codeexport which now no longer depends on TS.