Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localizedUrl() to handle .html routes correctly #1442

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 30, 2024

Description

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 30, 2024 6:09pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Jan 30, 2024 6:09pm

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Jan 30, 2024

size-limit report 📦

Path Size
/index.html 5.22 KB (0%)
/_astro/*.js 21.54 KB (0%)
/_astro/*.css 13.14 KB (0%)

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 6fd4513

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this to get a patch release out — would still love any feedback if folks have it and we can always make follow-up PRs!

@delucis delucis merged commit 1a642e4 into main Jan 31, 2024
9 checks passed
@delucis delucis deleted the dx-952/lang-select branch January 31, 2024 09:57
@delucis delucis added the 🌟 patch Change that triggers a patch release label Jan 31, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Select incorrectly appends locale when switching index pages
2 participants