feat: Add html attributes to hero action links #1485
Conversation
🦋 Changeset detectedLatest commit: 7fdba39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
i18n
There was a problem hiding this comment.
Thanks for the quick response @timokoessler — I Left a couple of small notes, but basically looks great! 🚀
One more thing, usually we only update the English docs and let our translators take care of updating their languages. In this case, it does seem to be safe to do, except for Indonesian and German (id and de). Those two pages are currently outdated and updating them in this PR would cause our translation tracker to treat them as “updated” even though this PR doesn’t actually do that.
There was a problem hiding this comment.
Looks good to me! Thanks for taking care of those updates @timokoessler.
I can take care of removing the German and Indonesian docs pages from this PR.
Will aim to bundle this in the next minor with #1175, so will merge when that is ready.
|
Thanks again for contributing this! Will be released shortly in v0.19 🙌 |
Description
This pull request changes the CallToAction component to add support for setting custom html attributes of hero action links.
Relates to @delucis request on #901