Add <Aside> component
#1499
Add <Aside> component
#1499
Conversation
🦋 Changeset detectedLatest commit: 89577ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
added
📚 docs
size-limit report 📦
|
There was a problem hiding this comment.
I had initially thought it would be ideal to share the HTML-building logic between this component, but when I looked at it, it felt kind of silly: the component is so simple that pulling the full hastscript pipeline feels wrong. It does mean some duplication — changes would require updating in two places — but given how minimal this is, I think this is OK.
I guess one could say that we could extract the variants and isAsideVariant from the remark plugin but considering we are already duplicating the SVGs and that we are not likely to have to update the variants often, I think it's fine to keep it as is and that it was a good call to not pull everything 👍
Really simple and nice component with a great error message for invalid types 🌟
Approving for later.
Description
AsideAstro component to our@astrojs/starlight/componentsmodule.:::note-style asides available in Markdown and MDX.Notes
I had initially thought it would be ideal to share the HTML-building logic between this component, but when I looked at it, it felt kind of silly: the component is so simple that pulling the full hastscript pipeline feels wrong. It does mean some duplication — changes would require updating in two places — but given how minimal this is, I think this is OK.
This PR copy/pastes the
urlToSlug()helper added in "Virtual" pages prototype #1175 so it can use it — will resolve the conflicts once "Virtual" pages prototype #1175 is merged.