Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfile & patch version of EC to latest #1553

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

hippotastic
Copy link
Contributor

Description

  • Just updates the dependency to the latest patch. No change for users.

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: 69c27e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 24, 2024 8:46am

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine, hopefully this was enough to always fix it 🤞

@hippotastic
Copy link
Contributor Author

It should! I hope I can add back the lazy-loading in a later patch again once we can reproduce the race condition.

@delucis
Copy link
Member

delucis commented Feb 24, 2024

Thanks again for diving into this issue and figuring out. I've added a changeset to this PR so we can release a patch forcing anyone to get the latest EC just in case there are a few projects out there that might get stuck on the buggy version.

@delucis delucis merged commit 8e09114 into withastro:main Feb 24, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 24, 2024
@hippotastic hippotastic deleted the update-ec-to-0.33.3 branch February 24, 2024 08:51
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 26, 2024
* main:
  [ci] format
  [ci] release (withastro#1555)
  Update lockfile & patch version of EC to latest (withastro#1553)
  [ci] format
  [ci] release (withastro#1546)
  Improve Zod errors (withastro#1542)
  Update `astro-expressive-code` dependency to `^0.33.2` (withastro#1541)
  i18n(ja): Update pages.mdx (withastro#1551)
  i18n(es): update `plugins` (withastro#1548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants