Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polish UI translations #1614

Merged
merged 5 commits into from Mar 20, 2024

Conversation

kpodurgiel
Copy link
Contributor

@kpodurgiel kpodurgiel commented Mar 11, 2024

Description

This PR adds Polish translations and fixes one minor typo in the i18n schema.


I've been on a fence with a few translations, here's what I am choosing and why:

  • search.shortcutLabel: (Naciśnij /, aby wyszukać) – the comma after the slash looks weird, but that's the rule in Polish. I've been thinking about:
    • Naciśnij / i szukaj ("Press / and serach"), but it's not better, as there are two single characters next to each other.
    • Aby wyszukać, naciśnij / – I can't tell if it's less or more visually annoying, and it sounds weird. It also conveys the meaning later in the sentence.
  • search.devWarning: uruchomić aplikację literally means "run the app". "previewing the site" doesn't translate well, and I think it could cause confusion.
  • page.previousLink: I added "page" to the word "Previous", as in Polish we decline adjectives according to nouns they go with, and leaving just "Poprzednia" / "Poprzedni" / "Poprzednie" implies the gender anyways, and it's rather rare to see it on the Polish websites. The same goes for nextLink.
  • aside.danger: That was the worst to translate, because direct translations of niebezpieczeństwo and zagrożenie are both strongly charged words (prime definitions regard a threat of hurting or offing someone), so I went with "ważne" – "important", which I've seen in other wikis to be used for aside red sections as well.

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: e428d23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 20, 2024 10:02am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 11, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions 🙌 I really appreciate you taking the time and explaining the translations that were a bit tricky and the decisions you made.

As a non-native speaker, this looks pretty good to me. I only left a few questions just to make sure that some translations are indeed expected to be identical to the English version.

Note that when approved, the PR will only be merged before a new version is released so that the documentation is only updated when the new language is available.

packages/starlight/translations/pl.json Outdated Show resolved Hide resolved
packages/starlight/translations/pl.json Show resolved Hide resolved
packages/starlight/translations/pl.json Show resolved Hide resolved
packages/starlight/translations/pl.json Show resolved Hide resolved
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@kpodurgiel
Copy link
Contributor Author

Okay! I've accepted the comment which added \n. The rest is correct. Many thanks for the review.

@kpodurgiel kpodurgiel requested a review from HiDeoo March 19, 2024 16:36
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the line ending issue and taking the time to go over all my questions 👍

Approving now so it's ready to merge when the next release will be going out.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @kpodurgiel and thanks for the thorough review @HiDeoo 🙌

@delucis delucis merged commit 78fc904 into withastro:main Mar 20, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants