New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polish UI translations #1614
Conversation
🦋 Changeset detectedLatest commit: e428d23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
2053fb5
to
af0f395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions 🙌 I really appreciate you taking the time and explaining the translations that were a bit tricky and the decisions you made.
As a non-native speaker, this looks pretty good to me. I only left a few questions just to make sure that some translations are indeed expected to be identical to the English version.
Note that when approved, the PR will only be merged before a new version is released so that the documentation is only updated when the new language is available.
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Okay! I've accepted the comment which added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the line ending issue and taking the time to go over all my questions 👍
Approving now so it's ready to merge when the next release will be going out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these @kpodurgiel and thanks for the thorough review @HiDeoo 🙌
Description
This PR adds Polish translations and fixes one minor typo in the i18n schema.
I've been on a fence with a few translations, here's what I am choosing and why:
search.shortcutLabel
:(Naciśnij /, aby wyszukać)
– the comma after the slash looks weird, but that's the rule in Polish. I've been thinking about:Naciśnij / i szukaj
("Press / and serach"), but it's not better, as there are two single characters next to each other.Aby wyszukać, naciśnij /
– I can't tell if it's less or more visually annoying, and it sounds weird. It also conveys the meaning later in the sentence.search.devWarning
:uruchomić aplikację
literally means "run the app". "previewing the site" doesn't translate well, and I think it could cause confusion.page.previousLink
: I added "page" to the word "Previous", as in Polish we decline adjectives according to nouns they go with, and leaving just "Poprzednia" / "Poprzedni" / "Poprzednie" implies the gender anyways, and it's rather rare to see it on the Polish websites. The same goes fornextLink
.aside.danger
: That was the worst to translate, because direct translations of niebezpieczeństwo and zagrożenie are both strongly charged words (prime definitions regard a threat of hurting or offing someone), so I went with "ważne" – "important", which I've seen in other wikis to be used for aside red sections as well.