Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation issue for sites with a single non-root language different from English #1709

Merged
merged 5 commits into from Apr 9, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Apr 4, 2024

What kind of changes does this PR include?

  • Changes to Starlight code

Description

This pull request fixes a UI strings translation issue for sites configured with a single non-root language different from English. In such case, the UI strings were not being translated correctly and were being displayed in English.

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: e6d58f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 9, 2024 10:37am

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this @HiDeoo! 💖

packages/starlight/utils/user-config.ts Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Apr 5, 2024
* main:
  [ci] format
  [ci] release (withastro#1714)
  Fix various Expressive Code translation issues (withastro#1708)
  Fix nested aside title rendering issue (withastro#1703)
  I18n(pt-PT): Add resources pages (withastro#1678)
  Add SST Ion & Font Awesome to site showcase (withastro#1710)
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the back and forth on this one @HiDeoo! LGTM! 🚀

@delucis delucis merged commit c5cd181 into withastro:main Apr 9, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 8, 2024
@sschultze
Copy link

Thank you @HiDeoo , this works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI text not translated when creating a multilingual site with only one locale
3 participants