Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Pkl file format icon #1728

Merged
merged 3 commits into from Apr 9, 2024
Merged

Adds a Pkl file format icon #1728

merged 3 commits into from Apr 9, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Apr 8, 2024

Description

  • As requested in Add `apple pkl` and `nix` icon #1599
  • Uses opacity attribute to reproduce the two-tone quality of the original icon.
  • Ran into an interesting issue with our standard <path /> style where with two paths, the second path ended up rendered inside the first: <path><path /></path>. Solved it for now by using a full </path> to close the first path.
  • Updated our file tree code to also understand the .pkl extension and map it to the new icon:
    several file tree entries including a config.pkl file with matching icon

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 061bfe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 8, 2024 6:59pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Apr 8, 2024 6:59pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Apr 8, 2024
@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.1 KB (+0.02% 🔺)
/_astro/*.js 21.55 KB (-0.03% 🔽)
/_astro/*.css 13.45 KB (0%)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me on both themes, and even when used with the <Icon /> component 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants