You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes Starlight respect Astro's build.format when building URLs.
This is considered WIP because there is still more work to do with the routes; we should be seeing https://localhost:3000/ without the trailing slash, but it's still there.
This commit makes Starlight respect Astro's `build.format` when
building URLs.
This is considered WIP because there is still more work to do with the
routes; we should be seeing `https://localhost:3000/` without the
trailing slash, but it's still there.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks again for the PR @jamescmartinez! Feel free to re-open if you have time to tackle this, but going to close as stale for now. No worries if you don’t have time, hopefully someone else can fix #180 soon!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delucis
force-pushed
the
main
branch
2 times, most recently
from
🚧 WIP for #180
This commit makes Starlight respect Astro's
build.formatwhen building URLs.This is considered WIP because there is still more work to do with the routes; we should be seeing
https://localhost:3000/without the trailing slash, but it's still there.