Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend default coverage.exclude #2079

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

AriPerkkio
Copy link
Contributor

@AriPerkkio AriPerkkio commented Jul 3, 2024

Description

  • What does this PR change? Give us a brief description.

    • Instead of manually copying Vitest's default values, use the default values from their public API:
  • Did you change something visual? A before/after screenshot can be helpful.

    • Nope

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: a857ef6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jul 3, 2024 4:06pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 3, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! I hadn’t realised this was available as an import. Thanks for making a PR 🌟

@delucis delucis merged commit a96d3e8 into withastro:main Jul 3, 2024
13 checks passed
@AriPerkkio AriPerkkio deleted the test/coverage-defaults branch July 3, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants