Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): keep original option color when hovering #612

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

KubaJastrz
Copy link
Contributor

@KubaJastrz KubaJastrz commented Aug 30, 2023

What kind of changes does this PR include?

  • Explicitly define option color in Select component

Description

Before

Screenshot.2023-08-30.10.42.36.687.mp4

After

Screenshot.2023-08-30.10.53.33.380.mp4

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: dc43713

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit dc43713
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64f1f5f435e42800081e59d4
😎 Deploy Preview https://deploy-preview-612--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Aug 30, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @KubaJastrz!

@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 1, 2023
@delucis delucis merged commit 1b367e3 into withastro:main Sep 1, 2023
10 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
@KubaJastrz KubaJastrz deleted the patch-1 branch September 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header select options are changing colors based on hover
2 participants