Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if a user’s project adds MDX or sitemap integrations #626

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 1, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • Users could potentially run into cryptic errors if they themselves added the MDX or sitemap integrations that come bundled with Starlight.
  • This heads that off by throwing a clearer error if we detect it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 66bf5f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 66bf5f1
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64f240db9ab90800089b3243
😎 Deploy Preview https://deploy-preview-626--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 1, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 1, 2023

size-limit report 📦

Path Size
/index.html 9.42 KB (0%)
/_astro/*.js 16.33 KB (0%)
/_astro/*.css 8.7 KB (0%)

@delucis delucis merged commit 5dd22b8 into main Sep 1, 2023
10 checks passed
@delucis delucis deleted the chris/integration-dedupe branch September 1, 2023 19:54
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants