Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a collapse function to the sidebar #63

Merged
merged 15 commits into from
May 18, 2023
Merged

Conversation

liruifengv
Copy link
Sponsor Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: d0929b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit d0929b4
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64669d2b77836d00075c63c3
😎 Deploy Preview https://deploy-preview-63--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@liruifengv liruifengv requested a review from delucis May 18, 2023 07:18
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liruifengv! Looks and works great.

Here are a few small tweaks to get this ready to merge.

packages/starlight/components/SidebarSublist.astro Outdated Show resolved Hide resolved
packages/starlight/components/SidebarSublist.astro Outdated Show resolved Hide resolved
packages/starlight/components/SidebarSublist.astro Outdated Show resolved Hide resolved
liruifengv and others added 4 commits May 18, 2023 16:48
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@liruifengv
Copy link
Sponsor Member Author

Thanks for your help. I have learned a lot.

@liruifengv liruifengv requested a review from delucis May 18, 2023 08:53
@liruifengv liruifengv requested a review from delucis May 18, 2023 09:18
@delucis
Copy link
Member

delucis commented May 18, 2023

Thanks @liruifengv — will release this now 🙌

@delucis delucis merged commit 823e351 into withastro:main May 18, 2023
7 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 18, 2023
@liruifengv liruifengv deleted the sidebar branch August 15, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants