fix: switched h2 to span in sidebar #810
Conversation
🦋 Changeset detectedLatest commit: b927c45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy Preview for astro-starlight processing.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hasham-qaiser
changed the title
|
I'm taking part in Hacktober Fest, and would appreciate it if anyone could kindly add the 'Oktoberfest-accepted' tag. would greatly appreciate it. |
sarah11918
added
the
hacktoberfest-accepted
There was a problem hiding this comment.
Thanks for your contribution 🙌
I think this change may need a changeset so that it can picked up in the changelog and communicated to users. Some people may rely on the current DOM structure for some tests or some styling, e.g. .sidebar h2. To create one, you can locally run the pnpm exec changeset command.
Note: tested the change with VoiceOver, I did not notice any difference in behavior.
There was a problem hiding this comment.
Thank you for fixing this @hasham-qaiser! Should be good to go. I just have one small suggestion for the changeset.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
delucis
changed the title
What kind of changes does this PR include?
Description
Closes # Sidebar h2 should be a span #808
What does this PR change? Give us a brief description.
switches the h2 to a span element.