Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize SVG paths for icons #864

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mehalter
Copy link
Contributor

What kind of changes does this PR include?

  • Changes to Starlight code

Description

This decreases the size of the UI icon svg paths by optimizing them.

Yes I am taking part in Hacktoberfest

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: 9e06144

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 11, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit 9e06144
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6526ae0b209a0300086a70a3

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Oct 11, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mehalter — these look good to me! Checked the preview vs the current site and don’t see any visual changes cause by this compression. Nice work.

Was this just running them through SVGOMG or did you have a different technique?

@delucis delucis added 🌟 patch Change that triggers a patch release hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest labels Oct 11, 2023
@mehalter
Copy link
Contributor Author

This was just running them through SVGOMG

@delucis
Copy link
Member

delucis commented Oct 11, 2023

Very cool. Didn’t realise how many we’d forgotten to do that for :-D

Will merge this one now as it doesn’t have any docs impact and will release it soon!

@delucis delucis merged commit b84aff2 into withastro:main Oct 11, 2023
10 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 11, 2023
@mehalter mehalter deleted the svg_optimization branch October 11, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants