Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove margin in markdown lists that contain inline code #924

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

kevinzunigacuellar
Copy link
Sponsor Member

What kind of changes does this PR include?

  • Changes to Starlight code

Description

Adds code to the ignore list, hence removing margin from markdown lists that contains inline code.

Note: Feel free to add more edge cases to the test page

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 7fec571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 7fec571
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6530091c0c26820008c542d6
😎 Deploy Preview https://deploy-preview-924--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Oct 18, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 18, 2023

size-limit report 📦

Path Size
/index.html 5.13 KB (0%)
/_astro/*.js 19.27 KB (0%)
/_astro/*.css 9.63 KB (+0.06% 🔺)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinzunigacuellar — makes sense to me!

Should be OK to merge once

  • we remove the test.mdx file
  • we add a changeset (patch)

@github-actions github-actions bot removed the 📚 docs Documentation website changes label Oct 18, 2023
@kevinzunigacuellar
Copy link
Sponsor Member Author

Thanks @kevinzunigacuellar — makes sense to me!

Should be OK to merge once

  • we remove the test.mdx file
  • we add a changeset (patch)

Done! 🚀

@kevinzunigacuellar kevinzunigacuellar added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 18, 2023
@kevinzunigacuellar kevinzunigacuellar merged commit 39d6302 into main Oct 18, 2023
9 checks passed
@kevinzunigacuellar kevinzunigacuellar deleted the kevin-list-css branch October 18, 2023 16:42
@astrobot-houston astrobot-houston mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline code breaks spacing in lists
3 participants