Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default locale routing bug when not using root locale #93

Merged
merged 1 commit into from May 26, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented May 26, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • During the bug bash several people hit a bug with i18n routing when not using a root locale. Basically, the /index.md for the default locale wasn’t getting its slug localized properly leading to weird things like /es/ fallback content overwriting /en/. This PR fixes that.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

🦋 Changeset detected

Latest commit: 50c55b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 50c55b5
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6470ba3ce1ea300008e6b185
😎 Deploy Preview https://deploy-preview-93--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 10.72 KB (0%)
/_astro/*.js 16.51 KB (0%)
/_astro/*.css 8.88 KB (0%)

@delucis delucis merged commit c6d7960 into main May 26, 2023
7 checks passed
@delucis delucis deleted the chris/fix-routing-bug branch May 26, 2023 13:57
@astrobot-houston astrobot-houston mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants