Strip leading and trailing slashes from autogenerate.directory
#944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
For sidebar autogenerated groups, we expect the
autogenerate.directory
to not include leading or trailing slashes:starlight/packages/starlight/utils/navigation.ts
Lines 90 to 97 in 01190b3
This can lead to empty groups in the sidebar if the user has a leading or trailing slash in their
autogenerate.directory
and no real hint or error message as to why like this Discord message.This pull request suggests that we strip leading and trailing slashes from
autogenerate.directory
in the Zod schema using a.transform()
.Note: I also updated some invalid paths in various
mockedAstroContent()
test calls following the rename ofreference/configuration.md
toreference/configuration.mdx
in #869.