Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point edit link to default locale file for fallback content #985

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

delucis
Copy link
Member

@delucis delucis commented Oct 24, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • Closes Edit page link fallback not working #981
  • Updates our edit link logic so that pages using fallback content no longer link to a non-existent page on GitHub but instead link to the default locale’s file.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: c604218

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 24, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit c604218
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/653806826732d40007b0595b

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Oct 24, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 24, 2023

size-limit report 📦

Path Size
/index.html 5.13 KB (0%)
/_astro/*.js 19.27 KB (0%)
/_astro/*.css 9.67 KB (0%)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes makes sense, played with it a bit locally and it works as expected. This looks good to me. 👍

@delucis delucis merged commit 92b3b57 into main Oct 24, 2023
9 checks passed
@delucis delucis deleted the chris/981 branch October 24, 2023 18:32
@astrobot-houston astrobot-houston mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit page link fallback not working
3 participants