Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout refactoring #99

Merged
merged 14 commits into from
May 30, 2023
Merged

Layout refactoring #99

merged 14 commits into from
May 30, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented May 30, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • Working on refactoring the page layout to support disabling the table of contents and “splash” pages without any navigation
  • Moved the “edit page” link to the page footer so it doesn’t vanish if there’s no ToC/on mobile screens

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

🦋 Changeset detected

Latest commit: a0f15d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit a0f15d4
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6475fb734d50930008c299c1
😎 Deploy Preview https://deploy-preview-99--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented May 30, 2023

size-limit report 📦

Path Size
/index.html 9.53 KB (-11.4% 🔽)
/_astro/*.js 16.51 KB (+0.11% 🔺)
/_astro/*.css 9.1 KB (+2.51% 🔺)

@delucis delucis merged commit d162b2f into main May 30, 2023
7 checks passed
@delucis delucis deleted the dx-161/landing-layout branch May 30, 2023 13:48
@astrobot-houston astrobot-houston mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants