Correctly permute all input constraints #753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP. It still requires a documentation pass.
It addresses the issues with applyInputs being either too greedy (applying to all valid scans as it did initially) or too conservative (applying to only one at a time). The method here is based on Power Sets, specifically using the neat bitflag trick of using a single iterator from 1..(N - 1) to signify the inclusiveness of the subsets.