Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add neofetch spec #1416

Merged
merged 5 commits into from Aug 18, 2022
Merged

feat: add neofetch spec #1416

merged 5 commits into from Aug 18, 2022

Conversation

grant0417
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Additional info:

@grant0417
Copy link
Member Author

Thanks to @Alonely0 for the spec!

@withfig-bot
Copy link
Collaborator

Overview

src/neofetch.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @grant0417,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

clo4
clo4 suggested changes Aug 17, 2022
View reviewed changes
src/neofetch.ts Outdated
},
{
name: "terminal",
description: "That hAcKeR black window you type on",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

@Alonely0 Alonely0 Aug 17, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on a cafe with my tablet doing the spec (my laptop's screen broke, and that's the only place with decent WiFi around) and I had like five 7-8 year olds around me calling me hacker because I was writing a JSON. They gave me the idea.

src/neofetch.ts Outdated
{
name: "--speed_type",
description: "Change the type of cpu speed to display",
args: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this should be suggestions

src/neofetch.ts Outdated
{
name: "--cpu_cores",
description: "Whether or not to display the number of CPU cores",
args: [{ name: "logical" }, { name: "physical" }, { name: "off" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/neofetch.ts Outdated
{
name: "--cpu_temp",
description: "Hide/Show cpu temperature",
args: [{ name: "C" }, { name: "F" }, { name: "off" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/neofetch.ts Outdated
{
name: "--gpu_type",
description: "Which GPU to display",
args: [{ name: "all" }, { name: "dedicated" }, { name: "integrated" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/neofetch.ts Outdated
{
name: "--disk_subtitle",
description: "What information to append to the Disk subtitle",
args: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/neofetch.ts Outdated
{
name: "--memory_unit",
description: "Memory output unit",
args: [{ name: "kib" }, { name: "mib" }, { name: "gib" }],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get the gist haha

@Alonely0
Copy link
Contributor

Thanks to @Alonely0 for the spec!

Thanks to you for fixing all the typos I made on the tablet & debugging it!

@Alonely0
Copy link
Contributor

Alonely0 commented Aug 17, 2022 •
edited

@grant0417 can you give me write access so I can fix my mess?
image

@grant0417 grant0417 linked an issue Aug 17, 2022 that may be closed by this pull request
Add neofetch completion spec #1395
Closed
3 tasks
@grant0417
Copy link
Member Author

Not sure i can give you perms

@Alonely0
Copy link
Contributor

Alonely0 commented Aug 17, 2022 •
edited

Not sure i can give you perms

Then test the gist on my other comment and if it works well, commit it. There should be a box somewhere saying something in the lines of "allow maintainers/reviewers to commit/edit" though.

@grant0417
Copy link
Member Author

Okay, put your gist in

@Alonely0
Copy link
Contributor

That's on me, I'm too used to rust.
Screenshot_2022-08-17-22-47-43-028_org bromite bromite

@Alonely0
Copy link
Contributor

Alonely0 commented Aug 17, 2022 •
edited

This is because somewhere I wrote

{ suggestions: "string" }

Instead of

{ suggestions: ["string"] }

Screenshot_2022-08-17-22-50-01-490_org bromite bromite

@Alonely0
Copy link
Contributor

Everything's green, @separaterecords if the spec works approve the PR

Alonely0
Alonely0 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@Alonely0 Alonely0 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be ok, but I can't test the spec because as I said earlier my laptop's screen is broken and I'm doing everything on my tablet. Shouldn't be merged until someone tests it.

fedeci
fedeci approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@fedeci fedeci left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thanks @Alonely0!

@grant0417 grant0417 merged commit cb23648 into master Aug 18, 2022
@fedeci fedeci deleted the neofetch branch August 19, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clo4 clo4 clo4 requested changes

@fedeci fedeci fedeci approved these changes

@Alonely0 Alonely0 Alonely0 approved these changes

@QuiiBz QuiiBz Awaiting requested review from QuiiBz

@mschrage mschrage Awaiting requested review from mschrage mschrage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add neofetch completion spec
5 participants
@grant0417 @withfig-bot @Alonely0 @fedeci @clo4