Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT] feat: prioritise suggestions based on if they are already an argument #208

Merged
merged 4 commits into from
May 24, 2021

Conversation

cstrnt
Copy link
Contributor

@cstrnt cstrnt commented May 19, 2021

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
See #81

What is the new behavior (if this is a feature change)?
Files which are already added with git add will have lower priority

Additional info:

@withfig-bot
Copy link
Collaborator

withfig-bot commented May 19, 2021

Overview

dev/git.ts:

Info:

Script:
git log --oneline
postProcess(function):

 function (out) {
      if (out.startsWith("fatal:")) {
        return [];
      }

      return out.split("\n").map((line) => {
        return {
          name: line.substring(0, 7),
          icon: "fig://icon?type=node",
          description: line.substring(7),
        };
      });
    }

Script:
git stash list
postProcess(function):

 function (out) {
      if (out.startsWith("fatal:")) {
        return [];
      }

      return out.split("\n").map((file) => {
        return {
          name: file.split(":")[2],
          insertValue: file.split(":")[0],
          icon: `fig://icon?type=node`,
        };
      });
    }

Script:
git diff --cached --name-only
postProcess(function):

 function (out) {
      if (out.startsWith("fatal:")) {
        return [];
      }

      return out.split("\n").map((file) => {
        return {
          name: file,
          insertValue: "-- " + file,
          icon: `fig://icon?type=file`,
          description: "staged file",
        };
      });
    }

Script:
git branch --no-color
postProcess(function):

 function (out) {
      if (out.startsWith("fatal:")) {
        return [];
      }
      return out.split("\n").map((elm) => {
        // current branch
        if (elm.includes("*")) {
          return {
            name: elm.replace("*", "").trim(),
            description: "current branch",
            icon: "⭐️",
            // priority: 100,
          };
        }

        return {
          name: elm.trim(),
          description: "branch",
          icon: "fig://icon?type=git",
        };
      });
    }

Script:
git remote -v
postProcess(function):

 function (out) {
      const remoteURLs = out.split("\n").reduce((dict, line) => {
        const pair = line.split("\t");
        const remote = pair[0];
        console.log(remote, pair);
        const url = pair[1].split(" ")[0];

        dict[remote] = url;
        return dict;
      }, {});

      return Object.keys(remoteURLs).map((remote) => {
        const url = remoteURLs[remote];
        let icon = "box";
        if (url.includes("github.com")) {
          icon = "github";
        }

        if (url.includes("gitlab.com")) {
          icon = "gitlab";
        }

        if (url.includes("heroku.com")) {
          icon = "heroku";
        }
        return {
          name: remote,
          icon: `fig://icon?type=${icon}`,
          description: "remote",
        };
      });
    }

Single Scripts:

  • git tag --list
  • git status --short

@withfig-bot
Copy link
Collaborator

Hello @cstrnt,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments have the arg property (arg: {})?
  • Are all options modular? E.g. a -u -x instead of -aux
  • Did you run npm run build?
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Member

@brendanfalk brendanfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as you change it back to script and postprocess, this seems good. Please test it yourself though!!

dev/git.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine on mac too, cool addition!

@cstrnt cstrnt merged commit 50b04ff into master May 24, 2021
@brendanfalk
Copy link
Member

Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants