New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spec for barnard59 #2217
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Hello @tpluscode,
Please add a 👍 as a reaction to this comment to show that you read this. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides a lot of instances of default: "[object Map]"
{ | ||
name: ["--variable"], | ||
description: "variable key value pairs", | ||
args: { name: "name=value", default: "[object Map]" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely a wrong default.
{ | ||
name: ["--variable"], | ||
description: "variable key value pairs", | ||
args: { name: "name=value", default: "[object Map]" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
{ | ||
name: ["--variable"], | ||
description: "variable key value pairs", | ||
args: { name: "name=value", default: "[object Map]" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Thank you for the review @grant0417 . As you can see, this was generated... About the bogus defaults. We have options with custom transforms which build a What about the linting problems? I can fix some casing but it also complains about |
Overviewsrc/barnard59.ts:Info:URLs:
|
ping @grant0417 |
https://github.com/zazuko/barnard59/