Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added spec for react native cli and npx #91

Merged
merged 1 commit into from Apr 6, 2021

Conversation

alexnaiman
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added spec for standalone react-native's cli and also for when using it from npx(npx react-native [command])
See #87

What is the current behaviour? (You can also link to an open issue here)
No specs for react-native

Additional info:

Some of the generators created, fail sometimes because some of the commands used inside the script timeout. Unfortunately, I couldn't figure out exactly a way to avoid that

@mschrage mschrage self-requested a review April 6, 2021 18:03
@mschrage mschrage self-assigned this Apr 6, 2021
Copy link
Member

@mschrage mschrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is is a 5 second timeout by default. I think we might make this configureable in the spec to give autocomplete maintainers more control. cc @falky97

Otherwise, this looks great! Thanks for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants