namespace conflict fixed #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@kdpujie 可以 rebase一下 提交信息吗？ |
|
@withlin 好的，我试试。不常用哈，哈哈 |
1. proto分包 2. NONE和兼容pb2的处理方式相同。否则启动时会panic
kdpujie
force-pushed
the
namespace-conflict
branch
from
9e10d8c
to
a39ef4b
Compare
|
@withlin rebase & squash has been done, pls check and merge it, thks. |
|
@kdpujie tks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要解决这个问题#58
protobuf官方规定，在go中应用时，同一个package下边是不能有相同枚举值的，不同版本的protobufs对该类情况处理方式不同，有的是警告，有的直接就panic了。详情见：https://developers.google.cn/protocol-buffers/docs/reference/go/faq
综合考虑了一下，我觉得修改pb定义的包结构是最合理的，也不会影响java端的使用。