Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Make mobile app build on Android #3350

Merged
merged 2 commits into from Jun 19, 2018

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Jun 19, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Related issues (delete if you don't know of any)
Closes expo/expo#1753

Note
When starting the React Native packager one has to clear the cache for this change to be reflected in the bundle—here we're using Expo, so exp start -c . (the -c flag has to be included just once).

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a couple of the plugins and presets we use in the root babelrc too? (specifically thinking of the GraphQL stuff)

@sjchmiela
Copy link
Contributor Author

Oh yes, sorry, I didn’t investigate the codebase further. 😕 I could try and figure out which plugins from the root are needed in mobile too if you’d like (but I guess it would take you significantly less time than me. 😃)

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for figuring this out, much much appreciated! 🙏

@mxstbr mxstbr changed the title Add simple Babel configuration to mobile project Make mobile app build on Android Jun 19, 2018
@mxstbr mxstbr merged commit 7b87431 into withspectrum:alpha Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants