This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Fix forwarding to newest version of JS bundle chunks #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceWorker installs are failing because old ServiceWorkers are trying to cache old versions of the bundle. Unfortunately, the hash changes with each release so if the SW tries to cache `UserSettings.asdf123.chunk.js` and we've released a new verion, that file is called something entirely different like `UserSettings.lkjli53.chunk.js` instead! This fixes the issue by forwarding old asset names to the new name, i.e. if a user requests `UserSettings.asdf123.chunk.js` but the current name is `UserSettingsings.lkjli53.chunk.js` we forward them to the new version. This should potentially fix some ServiceWorker problems!
brianlovin
approved these changes
Aug 11, 2018
|
I'm going to do one now! |
|
Sounds good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
ServiceWorker installs are failing because old ServiceWorkers are trying to cache old versions of the JavaScript chunks. Unfortunately, the bundle filenames change with each release so if the SW tries to cache
UserSettings.asdf123.chunk.jsand we've released a new verion, that file is called something entirely different likeUserSettings.lkjli53.chunk.jsinstead!This fixes the issue by forwarding old asset names to the new name, i.e. if a user requests
UserSettings.asdf123.chunk.jsbut the current name isUserSettingsings.lkjli53.chunk.jswe forward them to the new version.This should potentially fix some ServiceWorker problems!
Shoutout to @matheuss for pointing me in the right direction with his bug report.