Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

remove Flow version specify #3796

Closed
wants to merge 1 commit into from
Closed

remove Flow version specify #3796

wants to merge 1 commit into from

Conversation

ryota-murakami
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Related issues (delete if you don't know of any)
Closes #3795

I saw this PR #3795 failing by .flowconfig value.
I remove that value section In order to accept above PR.

Flow is not involved actual code, so use least version is fine!
I have a fascination to Flow I'd like to maintain it.(I'm reading OCaml book and attempt hacking flow馃槑)

Thanks馃榾

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we have this in the config is so that people with v78 on their local machine don't run into all sorts of errors when running on our codebase. We do need this there I'm pretty sure!

@ryota-murakami
Copy link
Contributor Author

@mxstbr Oh I see, that is so noisy.
I'm waiting for facebook/flow#4916 I want to only focus crucial part of all!

Thanks馃榾

@ryota-murakami ryota-murakami deleted the patch-1 branch August 18, 2018 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants