This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Don't double-load raven-js #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already loading raven via a script tag in the SSR template, but then still including the `raven-js` package in the frontend. This fixes it by only using the global raven from the script tag.
Generated by 🚫 dangerJS |
brianlovin
previously approved these changes
Nov 20, 2018
|
Happy to ignore peril and remove console logs before prod cut |
|
Actually @mxstbr want to just throw this up on alpha quickly to see that the context setting works, and then remove the consoles in a new commit? |
|
Deploying to alpha now! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already loading raven via a script tag in the SSR template, but then still including the
raven-jspackage in the frontend.This fixes it by only using the global raven from the script tag.
Should definitely be tested on alpha first.
Status
Deploy after merge (delete what needn't be deployed)