fix: update sort order #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Nov 17, 2021
packages/ui/utils/sortByNetwork.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| export function sortByNetwork(array) { | |||
There was a problem hiding this comment.
Suggested change
| export function sortByNetwork(array) { | |
| export function sortByNetwork(feeds) { |
Tommytrg
reviewed
Nov 17, 2021
packages/ui/utils/sortByNetwork.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| export function sortByNetwork(array) { | |||
| return array.sort((a, b) => { | |||
There was a problem hiding this comment.
Suggested change
| return array.sort((a, b) => { | |
| return feeds.sort((firstFeed, secondFeed => { |
gabaldon
force-pushed
the
sort-network2
branch
from
ffcd3f9
to
bbd3795
Compare
Tommytrg
reviewed
Nov 17, 2021
packages/ui/components/Main.vue
Outdated
| return 2 | ||
| } | ||
| }) | ||
| const result = this.feeds.feeds.map((feed) => { |
There was a problem hiding this comment.
Suggested change
| const result = this.feeds.feeds.map((feed) => { | |
| const allFeeds = this.feeds.feeds.map((feed) => { |
gabaldon
force-pushed
the
sort-network2
branch
from
bbd3795
to
5abf06e
Compare
Tommytrg
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.