feat: add conflux data feeds #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabaldon
force-pushed
the
add-conflux-feed
branch
2 times, most recently
from
a34c991
to
aad0260
Compare
gabaldon
force-pushed
the
add-conflux-feed
branch
from
aad0260
to
29fee3a
Compare
gabaldon
force-pushed
the
add-conflux-feed
branch
from
29fee3a
to
75c5315
Compare
gabaldon
force-pushed
the
add-conflux-feed
branch
2 times, most recently
from
793633c
to
f5bd8cc
Compare
aesedepece
reviewed
Aug 17, 2021
aesedepece
requested changes
Aug 17, 2021
packages/api/src/index.ts
Outdated
Comment on lines
41
to
44
| console.log( | ||
| 'resolve path: ', | ||
| path.resolve(process.env.DATA_FEED_CONFIG_PATH || './dataFeeds.json') | ||
| ) |
There was a problem hiding this comment.
Preferently, let's move path.resolve(process.env.DATA_FEED_CONFIG_PATH || './dataFeeds.json') into a const statement before the logging, then we can reuse on line 48 to avoid code repetition and ensure that we are logging the path that is actually being used.
Tommytrg
reviewed
Aug 18, 2021
gabaldon
force-pushed
the
add-conflux-feed
branch
3 times, most recently
from
5e03d68
to
99ddfc6
Compare
aesedepece
requested changes
Aug 24, 2021
aesedepece
requested changes
Aug 24, 2021
Tommytrg
requested changes
Aug 26, 2021
| @@ -77,7 +77,9 @@ export class Web3Middleware { | |||
| async entry => await this.listenToDataFeed(entry.feedInfo, entry.feedId) | |||
| ) | |||
|
|
|||
| Promise.all(promises) | |||
| Promise.all(promises).catch(err => { | |||
| console.error('[ERROR]', err.message) | |||
There was a problem hiding this comment.
Suggested change
| console.error('[ERROR]', err.message) | |
| console.error(err) |
packages/api/test/feeds.spec.ts
Outdated
Comment on lines
11
to
17
| const dataFeeds = JSON.parse( | ||
| fs.readFileSync( | ||
| path.resolve('./test/web3Middleware/dataFeeds.json'), | ||
| 'utf-8' | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| const dataFeeds = JSON.parse( | |
| fs.readFileSync( | |
| path.resolve('./test/web3Middleware/dataFeeds.json'), | |
| 'utf-8' | |
| ) | |
| ) | |
| import dataFeeds from './test/web3Middleware/dataFeeds.json' |
Comment on lines
13
to
16
| const dataFeeds = JSON.parse( | ||
| fs.readFileSync(path.resolve('./test/web3Middleware/dataFeeds.json'), 'utf-8') | ||
| ) | ||
|
|
There was a problem hiding this comment.
Suggested change
| const dataFeeds = JSON.parse( | |
| fs.readFileSync(path.resolve('./test/web3Middleware/dataFeeds.json'), 'utf-8') | |
| ) | |
| import dataFeeds from './test/web3Middleware/dataFeeds.json' |
gabaldon
force-pushed
the
add-conflux-feed
branch
from
9ced57f
to
f322c2d
Compare
aesedepece
approved these changes
Aug 27, 2021
Tommytrg
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14
close #20
close #64
close #63